-
-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: PS2 / PPSSPP / AppIcon Fixes to pass all compile workflow checks #2337
base: develop
Are you sure you want to change the base?
Build: PS2 / PPSSPP / AppIcon Fixes to pass all compile workflow checks #2337
Conversation
5faafec
to
3e4ee21
Compare
f867431
to
df44342
Compare
Builds for this Pull Request are available at |
df44342
to
35b8e4f
Compare
Builds for this Pull Request are available at |
7277a99
to
4c2aa5f
Compare
Builds for this Pull Request are available at |
6881812
to
c0742c0
Compare
I see this has active pushes still so I converted to a draft PR. Does this PR override the need for #2334 ? |
Signed-off-by: Joseph Mattello <[email protected]>
Signed-off-by: Joseph Mattello <[email protected]>
Signed-off-by: Joseph Mattello <[email protected]>
c0742c0
to
934fe49
Compare
This adds code to get PPSSPP to compile on Apple TV (so Provenance Project compiles on build tests using appletvos), and for Play to compile on iOS (updates the hardcoded paths), on top of 2334. So.. this could just be pointed to merge into 2334, or it could be overridden — it’s up to you. =] These are essentially fixes to get all the build checks to pass. AppIcon in Assets using Single Size (the 1024x1024 image) was throwing an error, which is fixed by specifying individual sizes. A script to auto generate various sizes of icons on iOS/watchOS is added, along with different sizes in Contents.json inside AppIcon. With this, everything should now compile on all tests. |
1b3c0d3
to
462dcac
Compare
462dcac
to
d1ea2bd
Compare
d01136d
to
c7a0588
Compare
Builds for this Pull Request are available at |
bro, you rule. I can't express enough how f'ing cool it is for you to put this much effort into these PRs. |
Just so you know, I changed the code sign for the sub-core frameworks because MacOS catalyst wouldn't work without it. This may be a bug, though, in the current XCode. I ran across a script the other day to fix the issue at build and sign time on a completely unrelated github issue I found. I don't remember where it was, though. I'll merge this PR as is, but I may temporarily have to revert back to the code signing for those modules or use an XCconfig file to make it easy for others. At this moment, I have to focus my energy on making it app store and cross-platform friendly since that's where the support for the project is, and that's what allows me to focus my time on the app again. Hit me up on Discord if you have it, or let me know how else we can talk one-on-one because I'd love to be able to help support your work through the support that Provenance has recently seen. |
Just FYI, I haven't merged this because it's part of a massive refactor branch I have. I'll push as soon as it builds though it will not have all cores activated in the build as I make spm projects for them. I'm thinking about how to do the libretro cmake cores, eitehr using SPM's built in cmake support (not sure if it's good), or a custom XCode build action which I have experience with for custom build tools like we're doing with the cmake thing. It will probalby just build the libs directly instead of making the xcode project, using cmake but for each platform and our shared MoltenVK path, and then link that to a swift / objc core in SPM. So far I have all the C only cores building in SPM and I'm making progess through the non cmake C++ cores. It's not hard, just a lot of cores to copy boiler plate and fix paths. the cores will be a lot more sane since they'll all be in the format
Cores can now be built without the app since all the PV* framewworks are seperate spm projects too. In theory, you could make a thin wrapper app to just boot single cores / roms for testing |
What does this PR do
Fixes PS2 paths to relative path
Fixes PPSSPP to compile on AppleTV (needs Apple TV MoltenVK to work on AppleTV)
Fixes AppIcon sizes to individual sizes (so it compiles on Azure Xcode 14.1)
Where should the reviewer start
How should this be manually tested
Any background context you want to provide
What are the relevant tickets
Screenshots (important for UI changes)
Questions