Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downloadText() method to accommodate .md file format #1342

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: downloadText() method to accommodate .md file format #1342

merged 1 commit into from
May 21, 2024

Conversation

9401adarsh
Copy link
Contributor

This PR fixes issue #1293.

Changes

  • Modify the downloadText() method in the privatebin.js file.

elrido
elrido approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@elrido elrido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll merge this manually, so I can re-run the PHP and JS unit tests and re-generate the SRI hashes for the templates - they need to be committed as well.

@elrido elrido merged commit 7c7b5ab into PrivateBin:master May 21, 2024
5 of 6 checks passed
@9401adarsh
Copy link
Contributor Author

Sure, I wasn't aware that the templates also had to be included in the merge request. Will keep in mind henceforth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elrido elrido elrido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@9401adarsh @elrido