Fix quantity misadjustment on status change from Canceled to any non-loggable #36123
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loggable Physical quantity was incorrectly increased when an order's status changed from a Canceled/Payment error state to any non-loggable state. The added condition correctly decreases the physical quantity of the affected products.
|
Hello @Macin609! This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community! |
matthieu-rolland
approved these changes
May 13, 2024
There was a problem hiding this comment.
looks good to me 👍
I launched UI tests on your PR just in case: https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/9066041693
|
Re-ran failed job on both ui tests and CI |
boherm
approved these changes
May 15, 2024
kpodemski
added
the
Waiting for QA
paulnoelcholot
added
the
Waiting for author
I think if you re-run the failed test it will work, I ran it too and it's all green for me: https://github.com/matthieu-rolland/ga.tests.ui.pr/actions/runs/9066041693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test?
1. Check the stock quantity for a selected product
2. Create an order for the selected product
Make sure the order is in a non-loggable state, such as Awaiting Bank Wire Payment. Check the stock quantity for the ordered product.
3. Change order status to Canceled or Payment error
Recheck the stock quantity for the ordered product. At this stage everything should be correct, the stock has returned to the state before the order was created.
4. Change order status to any non-loggable status for example Awaiting bank wire payment.
Expected behavior:
The amount of stock should return to the same as in the second step.
Behavior before bug fix:
The physical quantity was incorrectly increased by the quantity of ordered product.
5. Change order status again to Canceled or Payment error
Expected behavior:
The stock quantity should return to the same level as it was in the third step.
Behavior before bug fix:
Now you've somehow generated some additional stock :)
