Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup old JS files #36110

Closed
wants to merge 1 commit into from
Closed

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented May 7, 2024

Questions Answers
Branch? develop
Description? Removes old unused JS methods. Most of these are related to 1.6 product page and other migrated pages. I did not remove any methods that are actively used, possibly in 3rd party modules utilizing legacy components. Files that were not used at all were removed completely.
Type? refacto
Category? BO
BC breaks? yes
Deprecations? no
How to test?
UI Tests
Fixed issue or discussion?
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner May 7, 2024 12:13
@Hlavtox Hlavtox added this to the 9.0.0 milestone May 7, 2024
@prestonBot prestonBot added develop Branch Refactoring Type: Refactoring BC break Type: Introduces a backwards-incompatible break labels May 7, 2024
@Hlavtox Hlavtox mentioned this pull request May 7, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented May 7, 2024

@kpodemski Ready

Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not rush this PR, I see that you removed some commonly used functions like updateLinkRewrite or toggleLanguageFlags, basically all the functions that probably are still in use when people use HelperForm and old controllers.

There are some that are more safe to delete like:

stockManagementActivationAuthorization
orderOverwriteMessage
toggleShippingCost
orderDeleteProduct
changeCMSActivationAuthorization

I remember some modules where I've seen fancyChooseBox function, meaning those "helper functions" are relevant and should stay there, while those who are related to migrated pages, could probably be deleted.

etc.

It is too dangerous to remove all of these methods at once.

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label May 8, 2024
@Hlavtox Hlavtox closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Type: Introduces a backwards-incompatible break develop Branch Refactoring Type: Refactoring Waiting for author Status: action required, waiting for author feedback
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants