Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Dispatcher methods to set Controller/FrontController #36084

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Markus-Gurkcity
Copy link

Questions Answers
Branch? develop / 8.1.x
Description? Add setController/setFrontController methods to avoid bug in hookActionAfterLoadRoutes that protected variables can be set in Dispatcher
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? We have a module that wants to make an own Dispatch and needs to pass the information about the dispatched routes to the default PS Dispatcher in Hook actionAfterLoadRoutes. For this reason the protected variables "$controller" and "$front_controller" needs to be public or alternatively a setter methods is needed. Currently this can be only achieved with an Override of Dispatcher. You can read here how to test in deatil: #35971
UI Tests Please run UI tests and paste here the link to the run. Read this page to know why and how to use this tool..
Fixed issue or discussion? Fixes #35971
Related PRs
Sponsor company Gurkcity

@Markus-Gurkcity Markus-Gurkcity requested a review from a team as a code owner May 3, 2024 09:39
@prestonBot
Copy link
Collaborator

Hello @Markus-Gurkcity!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing Fixes #1234.

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

About linked issues

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added the Bug fix Type: Bug fix label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix
Projects
Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Can't set $controller in Dispatcher in hook actionAfterLoadRoutes
2 participants