Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specific scenario when multiple carriers are used. #36074

Merged
merged 1 commit into from May 15, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented May 2, 2024

Questions Answers
Branch? 8.1.x
Description? Fixes a major issue when multishipping is used and one of the packages does not have a carrier.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Follow steps in the issue.
UI Tests
Fixed issue or discussion? Fixes #36064
Related PRs
Sponsor company

@Hlavtox Hlavtox requested a review from a team as a code owner May 2, 2024 12:33
@Hlavtox Hlavtox added this to the 8.1.6 milestone May 2, 2024
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels May 2, 2024
@PrestaShop PrestaShop deleted a comment from prestonBot May 2, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label May 2, 2024
@matthieu-rolland matthieu-rolland modified the milestones: 8.1.6, 8.1.7 May 14, 2024
@paulnoelcholot
Copy link

Hello @Hlavtox,

I tested your PR and it's good for me! 🎉

Thanks!

image

@paulnoelcholot paulnoelcholot added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels May 15, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label May 15, 2024
@kpodemski kpodemski removed the Waiting for QA Status: action required, waiting for test feedback label May 15, 2024
@kpodemski kpodemski merged commit 55c8b19 into PrestaShop:8.1.x May 15, 2024
38 checks passed
@kpodemski
Copy link
Contributor

thank you @Hlavtox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
Status: To be tested
Development

Successfully merging this pull request may close these issues.

None yet

8 participants