Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP on refactoring lazy imports #13305

Closed
wants to merge 6 commits into from
Closed

Conversation

abrookins
Copy link
Collaborator

This isn't going to work because of how Python imports work -- all of these CLI commands depend on code that requires Python to evaluate prefect.__init__, which will load much of this code anyway. But this is just to show where I was at before realizing I should abandon the path @serinamarie.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 0598a09
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/663eaca3b4d871000842d264
😎 Deploy Preview https://deploy-preview-13305--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abrookins abrookins closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant