Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resuming flow runs to BypassCancellingFlowRunsWithNoInfra orchestration policy #13299

Merged
merged 1 commit into from May 13, 2024

Conversation

kevingrismore
Copy link
Contributor

Since Resuming is just a Scheduled state for flow runs that have been suspended, they have no associated infrastructure and should transition directly from Cancelling to Cancelled.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@kevingrismore kevingrismore added the fix A fix for a bug in an existing feature label May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 4331908
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/663e7f05424c0300082bdd6c
😎 Deploy Preview https://deploy-preview-13299--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kevingrismore kevingrismore marked this pull request as ready for review May 10, 2024 20:38
@kevingrismore kevingrismore requested a review from a team as a code owner May 10, 2024 20:38
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@kevingrismore kevingrismore merged commit 2e2b343 into main May 13, 2024
58 checks passed
@kevingrismore kevingrismore deleted the cancel-resuming-runs branch May 13, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants