Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip install prefect[dask] #13289

Merged
merged 3 commits into from May 13, 2024

Conversation

Andrew-S-Rosen
Copy link
Contributor

With the addition of the prefect-dask codebase directly into prefect, I think it's worth considering adding support for pip install prefect[dask] as a convenience option for end-users. I have enabled this by modifying setup.py.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

With the addition of the `prefect-dask` codebase directly into `prefect`, I think it's worth considering adding support for `pip install prefect[dask]` as a convenience option for end-users. I have enabled this by modifying `setup.py`.
@Andrew-S-Rosen Andrew-S-Rosen requested a review from a team as a code owner May 9, 2024 06:14
Copy link

netlify bot commented May 9, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 988a628
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/6642186428406100081753a9
😎 Deploy Preview https://deploy-preview-13289--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andrew-S-Rosen, this also aligns with what we'd like to do for some of our other collections, thanks for kicking this off!

@chrisguidry chrisguidry merged commit 1e1368a into PrefectHQ:main May 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants