Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow,runner): set streaming docker build progress to terminal by default #12408

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Mar 25, 2024

Example

Closes #12310

Unit tests added and modified to reflect changes.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

@hainenber hainenber requested a review from a team as a code owner March 25, 2024 15:54
Copy link

netlify bot commented Mar 25, 2024

👷 Deploy request for prefect-docs-preview pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 50ac424

Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hainenber! I think we can make this more flexible by adding a build_logs_sink kwarg to deploy which would allow users to pass in sinks other than stdout. It could default to stdout for convenience, but it will give users more flexibility for streaming Docker build logs.

@desertaxle desertaxle self-assigned this Apr 9, 2024
@hainenber
Copy link
Contributor Author

For some reasons, I couldn't get this tested properly as the I/O stream sys.stdout always got closed when I'm trying to compare 🤔

Result after executing pytest tests/test_flows.py

image

Copy link
Contributor

This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment.

@github-actions github-actions bot added the status:stale This may not be relevant anymore label Apr 30, 2024
Copy link
Contributor

This pull request was closed because it has been stale for 14 days with no activity. If this pull request is important or you have more to add feel free to re-open it.

@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:stale This may not be relevant anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make streaming Docker build progress to terminal when using flow.deploy() either default or clearer opt-in
3 participants