[BUG] Persist cookie name cannot feature specific characters #1537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡ PowerGrid - Pull Request
Motivation
Description
As we can see here, the
tableName
property is used to construct a persist cookie name. Table name can be any string, but if the string features characters such as " " (space) or other, the following exception will be thrown:With this limitation in mind, it is logical to hash persist key using cheap hash function such as
md5
. In addition to added table name hashing, this PR makesgetPersistKey
method protected which allows end user to customise it.Related Issue(s): None.
Documentation
This PR requires Documentation update?