test: sanity tests for primary and replica #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
Apr 30, 2024
|
|
||
| mkdir -p "$replica_host" | ||
|
|
||
| replica_dblog="$tmpdir/db_$replica_slot.log" |
There was a problem hiding this comment.
The replica logs go to a different log file.
steve-chavez
commented
Apr 30, 2024
| log "Running pg_basebackup for $replica_slot" | ||
|
|
||
| pg_basebackup -v -h "$PGHOST" -U postgres --wal-method=stream --create-slot --slot="$replica_slot" --write-recovery-conf -D "$replica_dir" \ | ||
| >> "$setuplog" 2>&1 |
There was a problem hiding this comment.
The replica startup process goes to the same $setuplog as the primary. I had dedicated file previously, but seemed better to have it all on one file since $setuplog is already light on details.
steve-chavez
commented
Apr 30, 2024
| if test "$_arg_replica" = "on"; then | ||
| replica_slot="replica_$RANDOM" | ||
| replica_dir="$tmpdir/$replica_slot" | ||
| replica_host="$tmpdir/socket_$replica_slot" |
There was a problem hiding this comment.
A different socket is created for the replica
steve-chavez
commented
Apr 30, 2024
Comment on lines
+107
to
+108
| export PGREPLICAHOST="$replica_host" | ||
| export PGREPLICASLOT="$replica_slot" |
There was a problem hiding this comment.
These are exported so the python tests can use it
* new --replica option to `postgrest-with-postgresql-*` * new command `postgrest-test-replica` * new sanity tests on test_replica.py * add postgrest-test-replica to postgrest-check and postgrest-coverage
steve-chavez
force-pushed
the
sanity-replica
branch
from
9cfb039
to
2e76116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgrest-with-postgresql-*postgrest-test-replicatest_replica.pypostgrest-test-replicatopostgrest-checkandpostgrest-coverage