Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ts specific issues #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/ts specific issues #41

wants to merge 3 commits into from

Conversation

csgulati09
Copy link
Contributor

@csgulati09 csgulati09 commented Mar 1, 2024

Title: TypeScript issues

Description:

  • Added few parameters in tsconfig to support largely supported tsconfig
  • Handled a case for reponse.json() in baseClient.ts, in case the json is null or not an object

Motivation:
Issue was reported by a user

Related Issue:
#42

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 1, 2024
@csgulati09 csgulati09 self-assigned this Mar 1, 2024
@@ -181,7 +185,8 @@ export abstract class ApiClient {

buildRequest(opts: FinalRequestOptions): { req: RequestInit, url: string } {
const url = new URL(this.baseURL + opts.path!)
const { method, path, query, headers: headers = {}, body } = opts;
// const { method, path, query, headers: headers = {}, body } = opts;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants