Faster octree radiusSearch #6045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvieth
added
changelog: enhancement
... by improving the check whether an octree node might contain a point within radius. Previously this was done by a sphere around the node center, now this done exact (like a rounded cube). Benchmarks: NormalEstimation (without OpenMP) with octree: | NormalEstimation | Old | New | |-------------------|-----------|------------| | r=0.01, cloud=milk| 914 ms | 756 ms | | r=0.01, cloud=mug | 1133 ms | 881 ms | | r=0.02, cloud=milk| 1979 ms | 1784 ms | | r=0.02, cloud=mug | 2642 ms | 2244 ms | Calling radiusSearch on every (valid) point of a cloud (r is tuned so that 5 and 50 neighbours are found on average, respectively): | Search | Old | New | |-----------------|-----------|------------| | r=0.0016, cloud1| 267 ms | 175 ms | | r=0.0022, cloud2| 319 ms | 210 ms | | r=0.0072, cloud3| 421 ms | 293 ms | | r=0.005, cloud1 | 440 ms | 356 ms | | r=0.0068, cloud2| 513 ms | 441 ms | | r=0.024, cloud3 | 877 ms | 873 ms |
mvieth
force-pushed
the
faster_octree_radiussearch
branch
from
4ca540c
to
6503e53
Compare
larshg
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... by improving the check whether an octree node might contain a point within radius. Previously this was done by a sphere around the node center (some nodes were checked although that would not have been necessary), now this is done exact (like a rounded cube).
Benchmarks:
NormalEstimation (without OpenMP) with octree:
Calling radiusSearch on every (valid) point of a cloud (r is tuned so that 5 and 50 neighbours are found on average, respectively):