Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT PROPOSAL: Bulk ops #51

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sleekslush
Copy link
Contributor

No description provided.

return dataMap[key]
protected rawGetMany = async (keys: string[]): Promise<Record<string, string | undefined>> => {
if (this.hasExtensionApi) {
return this.#primaryClient.get(keys)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sleekslush Does this work in Firefox?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, both chrome and firefox support arrays of keys

@louisgv
Copy link
Contributor

louisgv commented Jan 25, 2024

Can we also add getItems / setItems / removeItems alias? Those might be useful :-?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for the bulk operation (similar to the one in #48)

@sleekslush
Copy link
Contributor Author

Can we also add getItems / setItems / removeItems alias? Those might be useful :-?

We can just rename the ones I specified to this instead. I have no feelings towards it

@louisgv
Copy link
Contributor

louisgv commented Jan 26, 2024

Can we also add getItems / setItems / removeItems alias? Those might be useful :-?

We can just rename the ones I specified to this instead. I have no feelings towards it

SGTM 馃憤

@louisgv louisgv self-requested a review March 7, 2024 05:55
@faahim
Copy link

faahim commented Jun 2, 2024

This would be super useful! Not sure if this is blocked on something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants