Fix sitemap: false instruction not working
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pages in this theme use the
sitemap: falseinstruction to prevent their inclusion to thesitemap.xmlfile. Some examples of such pages:However this instruction doesn't seem to work. The current sitemap.xml of this theme's website contains the links to
404.html,redirect-page,search, despite all of them have thesitemap: falseinstruction. Apparently the only currently working way to exclude the page from the sitemap is setting thesitemap.excludevariable, like it is done here.This pull requests corrects the behavior of the
sitemap: falseinstruction thus allowing excluding a page from a sitemap both via thesitemapandsitemap.excludevariables.