Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for import with a single try #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thebigbone
Copy link

No description provided.

@PeterMosmans
Copy link
Owner

Thanks for the PR - however, it's the idea that the user gets a nice error message if the import goes awry. What would be the advantage of removing that statement?

@thebigbone
Copy link
Author

thebigbone commented May 16, 2023

I have not removed that statement. And you are right, for some reason it seems like that but if you look at my fork, it's not removed. I have just removed the double check for the imports, which seems unnecessary.

@thebigbone
Copy link
Author

Any update on this? As mentioned earlier, the error message is still there.

@PeterMosmans
Copy link
Owner

Thanks for the ping ;) -I agree on removing the double unnecessary try block. However, I do think there's value in showing a "nice" error message instead of the default one. Would you mind amending your PR with keeping the nice message? Thanks!

@thebigbone
Copy link
Author

thebigbone commented Apr 3, 2024

Do you have any suggestions? I think asking the user to install packages using requirements.txt, if the they haven't already, should be good enough. It would be tedious and unnecessary for the user to install packages one by one, as mentioned in the current error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants