Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new mono display #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

enelson1001
Copy link
Contributor

added SSD1306 I2C version
fix build_test.sh
update README.md

added SSD1306 I2C version
fix build_test.sh
update README.md
@PerMalmberg
Copy link
Owner

@enelson1001 Hey. I'm on vacation for another week, I'll have look at this afterwards.

@PerMalmberg
Copy link
Owner

Looks good, just wonder if all the changes in sdkonfig are just default values for a newer IDF?

@enelson1001
Copy link
Contributor Author

Must be because I did not make changes to that file.

@@ -64,12 +64,14 @@ If you are working on Windows or you don't want to install the dependencies on y
- ILI9341
- ST7735
- SH1107
- SSD1306(I2C)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a I2C device, then lets place it under the I2C section. Maybe we should reorganize the entire tree based on type instead of protocol type....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying do something like this
spi
|- display
| - sensors

i2c
|- display
| sensors

etc?

@PerMalmberg
Copy link
Owner

PerMalmberg commented Aug 11, 2021 via email

@enelson1001
Copy link
Contributor Author

Yes that does sound better.
1.Do you think we should include rmt as one of the types and move RGBled under it?
2. Where would Weigand go?
3. Still keep tree with io and under it spi, i2c and rmt?
4. Under spi i2c rmt do we want additional folders like display, sensor, digital, analog, rtc, power mgt etc or just limp everything together?

@PerMalmberg
Copy link
Owner

  1. Sure, why not.
  2. It's own category, maybe? "Oddballs" :)
  3. If it adds something
  4. If it doesn't just clutter the list, sure.

@enelson1001
Copy link
Contributor Author

I will start looking at what is involved to make this change this weekend. I will probably have a few more comments.

@enelson1001
Copy link
Contributor Author

Per
Please comment on the attached proposal before I begin working on this.
PullReq163_ProposedChanges.pdf

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants