Fix error when toggling 'Include Enchants' checkbox in trader #7572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the UpdateControlsWithItems() has been refactored right when this checkbox has been added, changing the expected argument format. No other callers use the obsolete arguments. Fixes PathOfBuildingCommunity#6216
teroshan
force-pushed
the
fix_trader_enchant_checkbox
branch
from
467df64
to
99b7524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6216
Description of the problem being solved:
Lua Error when toggling 'Include Enchants' in trader
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Any build will do
Before screenshot:
See linked issue #6216
After screenshot:
No error