Support Cold Snap more chill effect quality #7566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Cold Snap quality "% more effect of chill" not being parsed. Furthermore, fixes "more" modifiers on chill effect not being applied to enemy chill effect/bonechill. The latter also fixes #6777 and #5037.
Link to a build that showcases this PR:
https://pobb.in/u/Arcinde/hhdZhirZpJ8H
Before screenshot:
Cold Snap mod not being parsed:
Even after parsing Cold Snap mod, it is not calculated in effect of chill, despite the "chill effect mod" line below showing the correct value
Not calculated in bonechill damage increase
After screenshot:
Cold Snap mod is parsed:
Effect of chill correctly incorporates "more":
This value is taken up correctly for the bonechill damage increase of the main skill: