Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nec #388

Open
wants to merge 11 commits into
base: unstable
Choose a base branch
from
Open

Nec #388

wants to merge 11 commits into from

Conversation

khsa1
Copy link
Contributor

@khsa1 khsa1 commented Jan 24, 2021

This pull request adds support for NEC compilers.

Conflicts:
	packages/taucmdr/cf/software/binutils_installation.py
	packages/taucmdr/cf/software/tau_installation.py
	packages/taucmdr/model/target.py
@nchaimov
Copy link
Member

The tests appear to be failing because the workflow script is using the disabled set-env feature. I think this needs the changes to the workflow scripts from the sane-dependencies branch. We are planning to merge sane-dependencies into unstable soon, so it may make sense to merge these changes into sane-dependencies rather than unstable for now

@nchaimov nchaimov requested review from zbeekman and nchaimov and removed request for zbeekman January 26, 2021 21:20
Conflicts:
	packages/taucmdr/cf/software/binutils_installation.py
@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #388 (a19724b) into unstable (f683c83) will increase coverage by 0.13%.
The diff coverage is 76.78%.

❗ Current head a19724b differs from pull request most recent head 26888eb. Consider uploading reports for the commit 26888eb to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable     #388      +/-   ##
============================================
+ Coverage     69.50%   69.64%   +0.13%     
============================================
  Files            98       98              
  Lines          8665     8631      -34     
  Branches       1707     1569     -138     
============================================
- Hits           6023     6011      -12     
+ Misses         2126     2105      -21     
+ Partials        516      515       -1     
Flag Coverage Δ
CI 69.64% <76.78%> (+0.13%) ⬆️
unittests 69.64% <76.78%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/taucmdr/cf/software/binutils_installation.py 53.40% <40.00%> (-1.89%) ⬇️
packages/taucmdr/cf/software/tau_installation.py 55.45% <60.00%> (+0.25%) ⬆️
packages/taucmdr/model/target.py 60.86% <66.66%> (-0.85%) ⬇️
packages/taucmdr/cf/platforms.py 81.20% <75.00%> (-0.18%) ⬇️
packages/taucmdr/cf/compiler/host.py 100.00% <100.00%> (ø)
packages/taucmdr/cf/compiler/mpi.py 100.00% <100.00%> (ø)
packages/taucmdr/cf/software/zlib_installation.py 100.00% <100.00%> (ø)
packages/taucmdr/cli/commands/target/edit.py 71.08% <0.00%> (-18.46%) ⬇️
packages/taucmdr/cli/commands/target/create.py 49.77% <0.00%> (-2.29%) ⬇️
packages/taucmdr/cf/compiler/__init__.py 80.14% <0.00%> (-1.32%) ⬇️
... and 23 more

@zbeekman
Copy link
Member

zbeekman commented Feb 9, 2021

Hey @khsa1, sorry for the slow reply. I'm working on resolving this on your branch. I don't understand why that is failing either, FWIW, so for now I've disabled it. I'll merge my python 3 branch into this once I've sorted out this failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants