Add TPS From Chunk or Location #232
Conversation
| + io.papermc.paper.threadedregions.ThreadedRegionizer.ThreadedRegion<io.papermc.paper.threadedregions.TickRegions.TickRegionData, io.papermc.paper.threadedregions.TickRegions.TickRegionSectionData> | ||
| + region = world.regioniser.getRegionAtSynchronised(x, z); | ||
| + if (region == null) { | ||
| + return new double[]{ 20.0, 20.0, 20.0, 20.0, 20.0 }; |
There was a problem hiding this comment.
I don't think this is a good behavior, and it's totally undocumented, maybe change to Optional<double[]>/double @Nullable [] or throw and error?
There was a problem hiding this comment.
I modified it with a Nullable, which I think is the best option.
| + } else { | ||
| + io.papermc.paper.threadedregions.TickRegions.TickRegionData regionData = region.getData(); | ||
| + return new double[] { | ||
| + regionData.getRegionSchedulingHandle().getTickReport5s(System.nanoTime()).tpsData().segmentAll().average(), |
There was a problem hiding this comment.
Wouldn't it be better to at least store the time in nano seconds? As i remember it's not the fastest method to be called so many times
There was a problem hiding this comment.
I think there is already some internal storage of this, because typing tps will show it from the top regions. Would propose to consult that if possible.
There was a problem hiding this comment.
Wouldn't it be better to at least store the time in nano seconds? As i remember it's not the fastest method to be called so many times
Yes, calling it every time is not a good idea, so I preferred to store it in a variable (like /tps)
Currently, apart from using the dev-bundle, we have no way to check the TPS. Therefore, I propose implementing it with either the Location or the Chunk as an argument