Add multinomial operator #1000
Closed
Add multinomial operator #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
felixhjh
commented
Dec 23, 2022
felixhjh
commented
- Add multinomial operator
yeliang2258
reviewed
Dec 29, 2022
tests/test_auto_scan_multinomial.py
Outdated
| else: | ||
| num_samples = 1 | ||
|
|
||
| dtype = draw(st.sampled_from(["float32"])) |
There was a problem hiding this comment.
我参考了下，Paddle官方对multinomial api的测试用例，其中并没有输入为float64的测试用例。我在想是文档的问题吗？
|
可以merge一下develop，CI就可以通过了 |
yeliang2258
reviewed
Feb 1, 2023
tests/test_auto_scan_multinomial.py
Outdated
| "num_samples": num_samples, | ||
| "replacement": replacement, | ||
| "input_spec_shape": [], | ||
| "out_dtype": "int64", |
There was a problem hiding this comment.
这个是因为，Paddle multinomial的输出是int64，onnx算子的输出可以是int32或者int64（默认是int32），为了和Paddle对齐，就把onnx的输出都指定为int64，这里检验下输出的type
There was a problem hiding this comment.
但是out_dtype应该没在这个文件中用到吧
delete out_dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.