Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] 3D parallel on MLP with PIR #64369

Merged
merged 4 commits into from
May 17, 2024

Conversation

pkuzyc
Copy link
Contributor

@pkuzyc pkuzyc commented May 16, 2024

PR Category

Auto Parallel

PR Types

New features

Description

Pcard-67164
Support 3D parallel on MLP with PIR:

  1. Add unit test to check the loss in 3D parallel.
  2. Fix bugs in same_status and nd_mesh reshard function.

Copy link

paddle-bot bot commented May 16, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@pkuzyc pkuzyc marked this pull request as draft May 16, 2024 08:32
@pkuzyc pkuzyc marked this pull request as ready for review May 16, 2024 14:24
@pkuzyc pkuzyc changed the title [DistDialect] 3D parallel on MLP [DistDialect] 3D parallel on MLP with PIR May 17, 2024
@pkuzyc pkuzyc changed the title [DistDialect] 3D parallel on MLP with PIR [AutoParallel] 3D parallel on MLP with PIR May 17, 2024
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit f1a09ac into PaddlePaddle:develop May 17, 2024
31 checks passed
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 18, 2024
* pir 3D parallel on mlp

* fix bug in nd_mesh_reshard when [Partial(),Shard(0)]-->[Replicate(),Shard(0)]

* fix bug in 3D parallel unit test

* add _fetch_value test in ut
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 19, 2024
* pir 3D parallel on mlp

* fix bug in nd_mesh_reshard when [Partial(),Shard(0)]-->[Replicate(),Shard(0)]

* fix bug in 3D parallel unit test

* add _fetch_value test in ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants