[xpu] fix fc and resnet50 pass bugs, model: structextV1, resnet50. #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunyipower
requested review from
mjp9527,
zhupengyang and
hong19860320
as code owners
|
Thanks for your contribution! |
zhupengyang
reviewed
Jul 5, 2023
Comment on lines
+53
to
+58
| int check_product = 1; | ||
| for (unsigned int i = 0; i < mul_y_shape.size(); ++i) { | ||
| check_product *= mul_y_shape[i]; | ||
| } | ||
| return (mul_y_shape.size() == 2 && !op_desc.GetAttr<bool>("trans_x") && | ||
| check_product > 0); |
There was a problem hiding this comment.
如果是为了判断 mul_y 是 weight，可以在 38 行加 assert_is_persistable_var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR devices
XPU
PR types
Bug fixes
PR changes
PASS
Description
fix bugs of fc and resnet50 pass