Add metrics to the PSR2.ControlStructures.SwitchDeclaration sniff
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/3.x-metrics-for-switch-statements
branch
3 times, most recently
from
0f3ffea
to
ea5afa9
Compare
jrfnl
force-pushed
the
feature/3.x-metrics-for-switch-statements
branch
3 times, most recently
from
e76c34c
to
9103d79
Compare
jrfnl
force-pushed
the
feature/3.x-metrics-for-switch-statements
branch
from
9103d79
to
0fdb253
Compare
I've explicitly not added metrics for: * lowercase keyword as those are already recorded by the `Generic.PHP.LowerCaseKeyword` sniff * `break`/`return` not on a line by itself as that is already recorded by the `Generic.Formatting.DisallowMultipleStatements` sniff
jrfnl
force-pushed
the
feature/3.x-metrics-for-switch-statements
branch
from
0fdb253
to
782a930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreation of upstream PR squizlabs/PHP_CodeSniffer#1542:
Suggested changelog entry
PSR2/SwitchDeclaration: the sniff can now provide some metric on space usage in
switchstructures for a code base.