Ability to specify PSR-3 logger to log an autowire hit #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trait expects to be used in DefinitionSource interface implementation - allows setting logger to the source.
…and ReflectionBasedAutowiring.
…about autowiring were called
…est all available mutation methods calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is described here #608
Because autowiring is not a cheap operation and can be significantly optimized by compiling container - I, as a developer, want to know for what class autowiring happened.
To solve this, currently, there is only one option - disable autowiring and try to fix an exception in classes that weren't specified to autowire in the container definitions. In some cases, it's not a good solution.
This PR provides a new option to solve this - provide a logger and log autowiring hit, so I, as a developer, can smoothly fix it without production being broken.