update default cache permissions, and allow users to define their own #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you enable compilation in PHP-DI:
Directories are created with permission
0777
and files are created with0666
. This grants read+write to theother
group in a linux environment, which is widely accepted as unsafe practice.It is safer to create directories using
0775
and files with0664
by default.To that extent, I believe the compiler should be further enhanced, to allow users to configure permissions for better control over their environments.
This change sets new default permissions, and introduces a new
cachePermissions()
method, which a user can use to override those default permissions: