Add support for variadic arguments #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have errors in code formatting (https://github.com/PHP-DI/PHP-DI/pull/624/checks). Could you fix them? And you will probably need to merge master in your branch because of an update in Symfony's coding style. |
This makes ParameterResolver resolve variadic arguments correctly
tssge
force-pushed
the
variadic-arguments
branch
from
656a714
to
ecbd65b
Compare
|
Thank you for your feedback, I have fixed the formatting now |
mnapoli
reviewed
Oct 4, 2018
mnapoli
reviewed
Oct 4, 2018
|
Hello, i would be interested about the status of this, since I also faced the same issue with variadic arguments. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #619
This pull request is probably missing a lot of things, as I am not completely familiar with PHP-DI source yet. Please feel free to comment on what I could improve.
These changes pass all tests and a new test was added to support the new behavior.