Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not operator to False #8005

Closed

Conversation

Motchouk
Copy link

No description provided.

@mvorisek
Copy link
Contributor

TBH, ! is the perfect choise when the arg is of type bool. As PHP CS Fixer is not static analyser, it cannot know the type.

With this said, I belive this PR/feature is not wanted in the main repo, it is job for static analyser like https://github.com/phpstan/phpstan-strict-rules which will warn about ! when not applied strictly on bool only.

@keradus
Copy link
Member

keradus commented May 15, 2024

Agree with the previous statement.
It's too blind-decision to apply this rule, it should be done with extra care and I do not see it as part of main repository. Yet, I can understand the value to run it as one-timer, review and adjust everything manually, and then rely on stan to not introduce new issues. For that, please move this feature into custom rule

@keradus keradus closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants