feat: Clone PER-CS1.0 to PER-CS2.0 to prepare for adding new rules #7249
Conversation
Wirone
changed the title
|
How about that, I got everything to pass on first try. 😸 |
doc/ruleSets/PER-CS2.0.rst
Outdated
| Rule set ``@PER-CS2.0`` | ||
| ======================= | ||
|
|
||
| EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. |
There was a problem hiding this comment.
question
why Experimental?
what is experimental here?
(same for sibling Risky set)
There was a problem hiding this comment.
It's because first item on the checklist in #7247 - we just need to let people know that ruleset is not a final version of PER-CS v2.
There was a problem hiding this comment.
It's because first item on the checklist in #7247
it's not answering my question, actually ;)
we just need to let people know that ruleset is not a final version of PER-CS v2.
none rulset is considered final and each ruleset can evolve in future, they are not locked nor promised to not be modified ever in future.
2 best representative examples:
- PSR12 ruleset is present, yet not reflecting each rule described in PSR spec. amount of rules will increase over time, covering more and more aspects of PSR spec
- Symfony ruleset is present, yet standard is evolving over time, so also the ruleset is getting adjusted
with that, we never considered a rulset to be "experimental/internal" because "it's not complete".
with above, please remove the experimental marker. using this ruleset has nothing to do with experiments.
There was a problem hiding this comment.
it's not answering my question, actually ;)
It IS answering, @Crell did it because I asked for it. Whether that makes sense is totally different story 😉.
There was a problem hiding this comment.
i got you asked for it, but still that part didn't resolved my question 😓
later part did, thanks
There was a problem hiding this comment.
TL;DR, @Crell , please remove the experimental marker
doc/ruleSets/PER-CS2.0.rst
Outdated
| Rule set ``@PER-CS2.0`` | ||
| ======================= | ||
|
|
||
| EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. |
There was a problem hiding this comment.
| EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. | |
| Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. |
doc/ruleSets/PER-CS2.0Risky.rst
Outdated
| Rule set ``@PER-CS2.0:risky`` | ||
| ============================= | ||
|
|
||
| EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. This set contains rules that are risky. |
There was a problem hiding this comment.
| EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. This set contains rules that are risky. | |
| Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_. This set contains rules that are risky. |
|
|
||
| public function getDescription(): string | ||
| { | ||
| return 'EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; |
There was a problem hiding this comment.
| return 'EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; | |
| return 'Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; |
src/RuleSet/Sets/PERCS2x0Set.php
Outdated
|
|
||
| public function getDescription(): string | ||
| { | ||
| return 'EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; |
There was a problem hiding this comment.
| return 'EXPERIMENTAL: Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; | |
| return 'Rules that follow `PER Coding Style 2.0 <https://www.php-fig.org/per/coding-style/>`_.'; |
src/RuleSet/Sets/PERCS2x0Set.php
Outdated
| /** | ||
| * @internal | ||
| * | ||
| * PER Coding Style v1.0. |
There was a problem hiding this comment.
| * PER Coding Style v1.0. | |
| * PER Coding Style v2.0. |
keradus
changed the title
|
Thank you @Crell 🍻! |
Base change for #7247.
What it says on the tin. This should make PER-CS 2.0 a clone of PER-CS 1.0. We can then start adding new rules to it in future PRs.
@Wirone suggested marking it experimental. I don't know if there's a formal way to do that, so I just stuck it in the description text. If there's a better place for it, let me know and I can update. (Or just add yourself, I'm easy.)