Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Update PER set to v1.1 #6547

Closed
wants to merge 1 commit into from

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Aug 9, 2022

@jrmajor jrmajor force-pushed the feature/per11 branch 2 times, most recently from 3829eab to b02db11 Compare August 9, 2022 18:59
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 92.909% when pulling b02db11 on jrmajor:feature/per11 into 198293b on FriendsOfPHP:master.

@theodorejb
Copy link
Contributor

The cast_spaces rule should also be enforced per php-fig/per-coding-style#40.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Since this pull request has not had any activity within the last 90 days, I have marked it as stale.

I will close it if no further activity occurs within the next 14 days.

Please keep your branch up-to-date by rebasing it when main branch is ahead of it, thanks in advance!

@Crell
Copy link
Contributor

Crell commented Jun 5, 2023

PER-CS was released as 2.0, not 1.1. And per #6707, we're trying to restructure the way the PER-CS rules are defined anyway.

Once that's in, though, this would make a reasonable starting point for the PER-CS 2.0 ruleset.

@Wirone
Copy link
Member

Wirone commented Jun 6, 2023

This requires solid rebase after #6707 got merged, but personally I am not sure if it's good idea to provide all the changes in one PR. Maybe milestone would be better or issue with todo-list like here, but implemented with multiple smaller PRs?

CC: @keradus @kubawerlos

@github-actions github-actions bot added status/to verify issue needs to be confirmed or analysed to continue and removed status/stale labels Jun 6, 2023
@asamofal
Copy link

asamofal commented Jul 23, 2023

I noticed that Laravel Pint with the per preset doesn't follow the standard in some rules. That's why I'm here.

Is anyone working on this? I tried to figure out what's going on in this PR to see if I could help, but I think I've only caught some of the logic. It all looks too much for me. Maybe someone could create a milestone/issue with a more detailed to-do list (and maybe I could be helpful there).

I think PER support is really important, and I want to start using it in my project as soon as possible.

@Wirone
Copy link
Member

Wirone commented Jul 23, 2023

@asamofal There's #4502 for providing 100% coverage for PSR-12 / PER-CS v1. There's no other work for PER-CS v2 than this PR, which is outdated and should be closed IMHO. We should start with an issue or milestone, pointing all differences between v1 and v2 and implement it in steps, for easier review. This PR may help with determining scope, but I don't know if it's good to start with directly (rebasing, continuing work).

@Wirone Wirone mentioned this pull request Aug 23, 2023
16 tasks
@Wirone
Copy link
Member

Wirone commented Aug 23, 2023

I am going to close this in favor of #7247.

@Wirone Wirone closed this Aug 23, 2023
@Wirone Wirone removed the status/to verify issue needs to be confirmed or analysed to continue label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants