chore: fix mypy findings

austin_tui/__main__.py

@@ -26,7 +26,6 @@
 from typing import Any, List, Optional
 
 from austin import AustinError
-from austin import AustinTerminated
 from austin.aio import AsyncAustin
 from austin.cli import AustinArgumentParser
 from austin.cli import AustinCommandLineError
@@ -75,7 +74,7 @@ def __init__(self) -> None:
 
  self._args = AustinTUIArgumentParser().parse_args()
 
- self._view: AustinView = ViewBuilder.from_resource(
+ self._view: AustinView = ViewBuilder.from_resource( # type: ignore[assignment]
  "austin_tui.view", "tui.austinui"
  )
  mode = AustinProfileMode.MEMORY if self._args.memory else AustinProfileMode.TIME
@@ -137,6 +136,9 @@ def run(self) -> None:
  self.start(AustinTUIArgumentParser.to_list(self._args))
  )
  loop.run_forever()
+
+ self._view.close()
+
  if not austin.done():
  austin.cancel()
 
@@ -153,8 +155,6 @@ def shutdown(self) -> None:
  except AustinError:
  pass
 
- self._view.close()
-
  asyncio.get_event_loop().stop()
 
 

austin_tui/controllers/__init__.py

@@ -53,7 +53,7 @@ class Controller(ABC):
 
  def __init__(self, view: View) -> None:
  self.view = view
- self.model = self.__model__(view.mode)
+ self.model = self.__model__(view.mode) # type: ignore[call-arg]
 
  def push(self, event: Event, data: Any = None) -> Any:
  """Push an event to the controller.

austin_tui/controllers/austin.py

@@ -59,7 +59,7 @@ class AustinController(Controller):
  This controller is in charge of Austin data managing and UI updates.
  """
 
- __model__ = AustinModel
+ __model__ = AustinModel # type: ignore[assignment]
 
  def __init__(self, view: View) -> None:
  super().__init__(view)

austin_tui/controllers/system.py

@@ -54,7 +54,7 @@ class SystemController(Controller):
  fresh system data (e.g. CPU usage, duration etc...).
  """
 
- __model__ = SystemModel
+ __model__ = SystemModel # type: ignore[assignment]
 
  def __init__(self, *args: Any, **kwargs: Any) -> None:
  super().__init__(*args, **kwargs)

austin_tui/view/__init__.py

@@ -20,6 +20,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 
+from abc import ABC
 import asyncio
 import curses
 import sys
@@ -80,15 +81,15 @@ def _validate_ns(node: Element) -> None:
  raise ViewBuilderError(f"Node '{node}' has invalid namespace")
 
 
-class View:
+class View(ABC):
  """View object.
 
  All coroutines are collected and scheduled for execution when the view is
  opened.
  """
 
  def __init__(self, name: str) -> None:
- self._tasks = []
+ self._tasks: List[asyncio.Task] = []
 
  self._event_handlers: Dict[str, EventHandler] = {}
 
@@ -98,7 +99,7 @@ def __init__(self, name: str) -> None:
  self.palette = Palette()
  self.root_widget = None
 
- def _create_tasks(self) -> List[asyncio.Task]:
+ def _create_tasks(self) -> None:
  loop = asyncio.get_event_loop()
  self._tasks = [
  loop.create_task(coro())

austin_tui/view/austin.py

@@ -67,7 +67,8 @@ def on_quit(self) -> bool:
  """Handle Quit event."""
  if not self.callback:
  raise RuntimeError("AustinTUI requires a callback to handle quit events.")
- self.callback(self.Event.QUIT)
+ self.callback(self.Event.QUIT, None)
+ return False
 
  def on_next_thread(self) -> bool:
  """Handle next thread event."""

austin_tui/widgets/markup.py

@@ -82,7 +82,7 @@ def attr(self) -> int:
  attr |= curses.A_REVERSE
  return attr
 
- def write(
+ def write( # type: ignore[override]
  self, window: "curses._CursesWindow", y: int, x: int, maxlen: int = None
  ) -> int:
  """Write the chunk on the given curses window.
@@ -129,7 +129,7 @@ def __len__(self) -> int:
  """The actual string length."""
  return sum(len(_) for _ in self._chunks)
 
- def write(
+ def write( # type: ignore[override]
  self, window: "curses._CursesWindow", y: int, x: int, maxlen: int = None
  ) -> int:
  """Write the attribute string on the given window.

austin_tui/widgets/table.py

@@ -69,7 +69,7 @@ def _draw_row(self, i: int, row: List[Any]) -> None:
  else:
  text = row[j]
  win.addstr(i, x, text[: available - x], 0)
- delta = min(text[: available - x], len(text))
+ delta = min(available - x, len(text))
  x += delta
 
  def set_data(self, data: TableData) -> None:

mypy.ini

@@ -1,4 +1,5 @@
 [mypy]
+disable_error_code = attr-defined,import,union-attr
 
 [mypy-nox.*,pytest,psutil]
 ignore_missing_imports = True

noxfile.py

@@ -2,8 +2,7 @@
 
 import nox
 
-
-nox.options.sessions = ["lint"]
+nox.options.sessions = ["lint", "mypy"]
 
 
 # ---- Configuration ----
@@ -59,7 +58,7 @@ def lint(session):
 @nox.session(python=SUPPORTED_PYTHON_VERSIONS)
 def mypy(session):
  session.install("mypy")
- session.run("mypy", *MYPY_LOCATIONS)
+ session.run("mypy", "--show-error-codes", *MYPY_LOCATIONS)
 
 
 @nox.session(python="3.7")