Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes, Improvements & Formatting #23

Closed
wants to merge 5 commits into from
Closed

Conversation

Nydragon
Copy link

@Nydragon Nydragon commented May 8, 2024

Hey, I made some modifications to the script to fix some "bugs" and modify some behaviour.

Remove More Options

This way all the subcommands of more options are directly searchable and one does not need to go through an extra menu to, for example, activate a VPN connection.

Update configuration place & order

Updated the configuration parsing order to check for configuration in

  • ~/.config/rofi-network-manager/*
  • ~/.config/rofi/rofi-network-manager.*
  • $SCRIPT_DIR/*

In the stated order. The reason is that user configuration should take precedence over the default configuration
and moving the configuration to a specific directory is to avoid any potential conflict with rofi configurations.

Clicking on the column header SSID SECURITY does not close the program

rofi-network-manager restarts when the column header is clicked instead of closing.

Format & spread out code

I found that some lines where very long and/or hard to read, so I split them and applied shfmt to the entire file.

Updated the configuration parsing order to check for configuration in

- ~/.config/rofi-network-manager/*
- ~/.config/rofi/rofi-network-manager.*
- $SCRIPT_DIR/*

In the stated order. The reason is that user configuration should take precedence over the default configuration
and moving the configuration to a specific directory is to avoid any potential conflict with rofi configurations.
@P3rf
Copy link
Owner

P3rf commented May 19, 2024

If the pull request had been about formatting and headers only (in which case I would have simply called the main function), I would have accepted it. However, I disagree with the naming of the user's configuration files. The "~More Options" label is there because I want the main "screen" to focus on WiFi connections.

I regularly receive messages about how to install the script. It is simply a Bash script that was not intended to be "packaged." In the next commit, I will add an installation script so it can be installed as a user package.

P.S. In line 107, remove the new line at the end of the Open Connection Editor to avoid an empty line.

@P3rf P3rf closed this May 19, 2024
@Nydragon
Copy link
Author

Hey, thanks for the message! I split the column header fix & formatting into a different branch and submitted it as a PR (#24), so feel free to merge it if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants