-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pagination: make previous and next buttons accessible #2102
Open
MewenLeHo
wants to merge
33
commits into
main
Choose a base branch
from
main-mlh-fix-a11y-pagination
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
MewenLeHo
commented
Jun 23, 2023
MewenLeHo
commented
Jun 23, 2023
MewenLeHo
commented
Jun 26, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
13 tasks
ok, with the "title", i think, it's usable :) |
This comment was marked as outdated.
This comment was marked as outdated.
All looks good to me. |
louismaximepiton
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #2008
Description
We currently have an a11y problem in pagination related to WCAG 2.1 Success Criterion 1.3.1 Info and Relationships (Level A) and WCAG 2.1 Success Criterion 1.3.2 Meaningful Sequence (Level A). It stated that all content must be available in text even when the CSS stylesheets are disabled.
If we disabled our stylesheets, the result is:
So:
It appears that the
<
and>
are conveying informations so they need to be focusable even when CSS is off.With this prototype:
Please note that I made the change only on the
previous button
to show the difference with thenext button
.Motivation & Context
Improve a11y of pagination component
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge