Add GetValueEndPoint() to Manager #2013
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces helper function: uint8 Manager::GetValueEndPoint(ValueID const &_id) The purpose is - To allow printing of "End Point" for diagnosis. End Point is what is used in conversation with a device, not "Instance". - To allow selection of Values with certain End Point for use in "Multi Channel Association". This class does not accept "Instance" Adds tests to cpp/test/Manager_test.cpp - verifies a (fake) mapping and tests exception thrown. Adds "TestHelper" as a friend to allow testing of existing OZW classes without refactoring and without having to start a "real" Manager and Driver (which would have its merits but would be to involved and heavy)
|
Thanks. Will review soon. |
|
Wasn't aware that Github would close my PR if I removed the branch. Was doing some spring cleaning 馃檪... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces helper function:
uint8 Manager::GetValueEndPoint(ValueID const &_id)
The purpose is
Adds tests to cpp/test/Manager_test.cpp - verifies a (fake) mapping and tests exception thrown.
Adds "TestHelper" as a friend to allow testing of existing OZW classes without refactoring and without having to start a "real" Manager and Driver (which would have its merits but would be to involved and heavy)
If this PR gets accepted, I will update ozwcp to display the "endpoint".
The "TestHelper" can (will) be re-used to test a recent commit, 79663e1
by gizmocuz, "Making GetValue code more consistent, Releasing values", mainly as a proof-of-concept on how to test things.
I am not totally new to testing, but I am new to using "google test" and testing of C++ code so please give an honest opinion 馃檪