gaussianmechanism function in sklearn_pipeline.py #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Tho I would suggest next time to make the commit bit by bit instead of all of it straight away. It will help to managed changes in codebase. Regardless, I see no issue with the implementation. @chinmayshah99 Can we merge this soon? |
|
seems like there are conflicts. Please look into this. |
|
@SandeepJabez there seems to be a bit more conflicts if you can look into it. |
yes, i was trying to fix, but ended up making more, I will look into them |
SKLearn Pipeine use LaplaceDistribution Class from Google DP (OpenMined#408)
|
@chinmayshah99 @grilhami I have fixed the conflicts, kindly take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have written block of code for the function of gaussian mechanism