Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture american-dj/encore-lp5ip #3923

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add fixture american-dj/encore-lp5ip #3923

wants to merge 1 commit into from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture american-dj/encore-lp5ip

Thank you @HickmanLighting!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 21, 2024
@github-actions GitHub Actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ american-dj / encore-lp5ip: d-light / attributes-correctness
  • ✔️ american-dj/encore-lp5ip-10ch.xml
✔️ american-dj / encore-lp5ip: dmxcontrol3 / channel-numbers
  • ✔️ american-dj-encore-lp5ip-10ch.xml
✔️ american-dj / encore-lp5ip: dragonframe / json-schema-conformity
  • ✔️ american-dj/encore-lp5ip.json
  • ✔️ manufacturers.json
❌ american-dj / encore-lp5ip: millumin / json-schema-conformity
  • ❌ american-dj/encore-lp5ip.jsonfixture/physical/DMXconnector "5-pin XLR IP65" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
✔️ american-dj / encore-lp5ip: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/American-DJ-Encore-LP5IP.qxf
❌ american-dj / encore-lp5ip: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/American-DJ-Encore-LP5IP.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Technical', attribute 'DmxConnector': [facet 'enumeration'] The value '5-pin XLR IP65' is not an element of the set {'3-pin', '5-pin', '3-pin and 5-pin', '3-pin IP65', '5-pin IP65', '3.5 mm stereo jack', 'Wireless', 'Other'}.

kengruven
kengruven reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looked good as far as it went but it turns out it was missing quite a lot. Let me know if these changes look OK.

fixtures/american-dj/encore-lp5ip.json
"https://www.adj.com/encore-lp5ip"
],
"video": [
"https://www.youtube.com/watch?v=1B8vrShd7zw&t=1s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.youtube.com/watch?v=1B8vrShd7zw&t=1s"
"https://www.youtube.com/watch?v=1B8vrShd7zw"

fixtures/american-dj/encore-lp5ip.json
},
"modes": [
{
"name": "10ch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "10ch",
"name": "10-channel",

fixtures/american-dj/encore-lp5ip.json
Comment on lines +346 to +347
"colorTemperatureStart": "2700K",
"colorTemperatureEnd": "2700K"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"colorTemperatureStart": "2700K",
"colorTemperatureEnd": "2700K"
"colorTemperature": "2700K"

fixtures/american-dj/encore-lp5ip.json
Comment on lines +352 to +353
"colorTemperatureStart": "3200K",
"colorTemperatureEnd": "3200K"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"colorTemperatureStart": "3200K",
"colorTemperatureEnd": "3200K"
"colorTemperature": "3200K"

fixtures/american-dj/encore-lp5ip.json
Comment on lines +358 to +359
"colorTemperatureStart": "4000K",
"colorTemperatureEnd": "4000K"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"colorTemperatureStart": "4000K",
"colorTemperatureEnd": "4000K"
"colorTemperature": "4000K"

fixtures/american-dj/encore-lp5ip.json
},
{
"dmxRange": [1, 4],
"type": "ColorPreset"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual has a table with every color, but until we support RGBL (#437), there's no direct way to encode most of them.

fixtures/american-dj/encore-lp5ip.json
}
},
"modes": [
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
{
"name": "4-channel",
"shortName": "4ch",
"channels": [
"Red",
"Green",
"Blue",
"Lime"
]
},
{
"name": "7-channel",
"shortName": "7ch",
"channels": [
"Red",
"Green",
"Blue",
"Lime",
"Shutter / Strobe",
"Dimmer",
"Dimmer fine"
]
},
{
"name": "8-channel",
"shortName": "8ch",
"channels": [
"Red",
"Red fine",
"Green",
"Green fine",
"Blue",
"Blue fine",
"Lime",
"Lime fine"
]
},
{

fixtures/american-dj/encore-lp5ip.json
}
]
},
"Dimmer": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Dimmer": {
"Auto Programs": {
"capabilities": [
{
"dmxRange": [0, 31],
"type": "NoFunction"
},
{
"dmxRange": [32, 63],
"type": "Effect",
"effectName": "Auto Program 1"
},
{
"dmxRange": [64, 95],
"type": "Effect",
"effectName": "Auto Program 2"
},
{
"dmxRange": [96, 127],
"type": "Effect",
"effectName": "Auto Program 3"
},
{
"dmxRange": [128, 159],
"type": "Effect",
"effectName": "Auto Program 4"
},
{
"dmxRange": [160, 191],
"type": "Effect",
"effectName": "Auto Program 5"
},
{
"dmxRange": [192, 223],
"type": "Effect",
"effectName": "Auto Program 6"
},
{
"dmxRange": [224, 255],
"type": "Effect",
"effectName": "Auto Program 7"
}
]
},
"Auto Program Speed": {
"capability": {
"type": "EffectSpeed",
"speedStart": "slow",
"speedEnd": "fast"
}
},
"Auto Program Fade": {
"capability": {
"type": "EffectDuration",
"durationStart": "short",
"durationEnd": "long"
}
},
"Dim Curves": {
"capabilities": [
{
"dmxRange": [0, 20],
"type": "Maintenance",
"comment": "Square"
},
{
"dmxRange": [21, 40],
"type": "Maintenance",
"comment": "Linear"
},
{
"dmxRange": [41, 60],
"type": "Maintenance",
"comment": "Inv. square"
},
{
"dmxRange": [61, 80],
"type": "Maintenance",
"comment": "S. Curve"
},
{
"dmxRange": [381, 255],
"type": "NoFunction"
}
]
},
"Special Functions": {
"capabilities": [
{
"dmxRange": [0, 15],
"type": "Maintenance",
"comment": "Default to Unit Setting"
},
{
"dmxRange": [16, 30],
"type": "Maintenance",
"comment": "900 Hz LED refresh rate"
},
{
"dmxRange": [31, 45],
"type": "Maintenance",
"comment": "1000 Hz LED refresh rate"
},
{
"dmxRange": [46, 60],
"type": "Maintenance",
"comment": "1100 Hz LED refresh rate"
},
{
"dmxRange": [61, 75],
"type": "Maintenance",
"comment": "1200 Hz LED refresh rate"
},
{
"dmxRange": [76, 90],
"type": "Maintenance",
"comment": "1300 Hz LED refresh rate"
},
{
"dmxRange": [91, 105],
"type": "Maintenance",
"comment": "1400 Hz LED refresh rate"
},
{
"dmxRange": [106, 120],
"type": "Maintenance",
"comment": "1500 Hz LED refresh rate"
},
{
"dmxRange": [121, 135],
"type": "Maintenance",
"comment": "2500 Hz LED refresh rate"
},
{
"dmxRange": [136, 150],
"type": "Maintenance",
"comment": "4000 Hz LED refresh rate"
},
{
"dmxRange": [151, 165],
"type": "Maintenance",
"comment": "5000 Hz LED refresh rate"
},
{
"dmxRange": [166, 180],
"type": "Maintenance",
"comment": "10000 Hz LED refresh rate"
},
{
"dmxRange": [181, 195],
"type": "Maintenance",
"comment": "15000 Hz LED refresh rate"
},
{
"dmxRange": [196, 210],
"type": "Maintenance",
"comment": "20000 Hz LED refresh rate"
},
{
"dmxRange": [211, 225],
"type": "Maintenance",
"comment": "25000 Hz LED refresh rate"
},
{
"dmxRange": [226, 255],
"type": "NoFunction"
}
]
},
"Dimmer": {

fixtures/american-dj/encore-lp5ip.json
"Dimmer",
"Dimmer fine"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
},
{
"name": "13-channel",
"shortName": "13ch",
"channels": [
"Red",
"Green",
"Blue",
"Lime",
"Color Macros",
"CTC",
"Color Temperature Macros",
"Shutter / Strobe",
"Dimmer",
"Dimmer fine",
"Dim Mode",
"Dim Curves",
"Special Functions"
]
},
{
"name": "16-channel",
"shortName": "16ch",
"channels": [
"Red",
"Green",
"Blue",
"Lime",
"Color Macros",
"CTC",
"Color Temperature Macros",
"Shutter / Strobe",
"Dimmer",
"Dimmer fine",
"Auto Programs",
"Auto Program Speed",
"Auto Program Fade",
"Dim Mode",
"Dim Curves",
"Special Functions"
]
}

fixtures/american-dj/encore-lp5ip.json
"capabilities": [
{
"dmxRange": [0, 0],
"type": "NoFunction"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "NoFunction"
"type": "NoFunction",
"helpWanted": "Is the CTC channel only active when this channel is 0? Do we need switching?"

@HickmanLighting
Copy link

HickmanLighting commented May 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengruven kengruven kengruven left review comments

Assignees
No one assigned
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FloEdelmann @HickmanLighting @kengruven