Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor|fix|test)(frontend): update tests after setting modals upgrade #1467

Merged
merged 1 commit into from Apr 30, 2024

Conversation

amanape
Copy link
Collaborator

@amanape amanape commented Apr 30, 2024

Summary

Changes introduced in #1319 caused the settings test to fail because they did not take into account the new property. They have since been updated to do so.

Additional fixes

  • A test in settings modal failed because the modal did not save settings due to its implementation. There were some cases where the save button would be disabled when API key was empty, because any empty input resulted in disabling the button. Of course this is not desired with the new change, so the isDisabled logic has been updated to take into account the api key.
  • Removed package-lock.json from root (accidentally added from a previous commit)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@31c1a2d). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1467   +/-   ##
=======================================
  Coverage        ?   58.53%           
=======================================
  Files           ?       82           
  Lines           ?     3429           
  Branches        ?        0           
=======================================
  Hits            ?     2007           
  Misses          ?     1422           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amanape amanape requested a review from Sparkier April 30, 2024 11:33
Comment on lines +90 to +93
Object.entries(settings)
// filter api key
.filter(([key]) => key !== "LLM_API_KEY")
.some(([, value]) => !value) ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Sparkier Sparkier merged commit 5f2d6f5 into OpenDevin:main Apr 30, 2024
21 checks passed
@amanape amanape deleted the sp-update-tests branch April 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants