Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions for github push and send PR #1415
Add actions for github push and send PR #1415
Changes from all commits
958c43b
bb1c54e
3f21713
1bca630
0d02ca5
25d0b13
f2afa77
0013639
02521c4
12eee32
0208702
01a98ba
f27680b
bc5c234
48f4100
3a7e51b
93e056d
8d96748
6a97884
a47a957
ce8e3fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error handling for push? A common error would be permission related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now if the command fails it will return the failed command and failure message (after deleting the remote), so I think this might be OK as-is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Rate limiting error should be rare and I don't think we need to handle that. Permission error would have to be resolved by the user anyways. #1290 aims to add support for agent-user interaction, which might be helpful for users to intervene and address permission issues, if any.