-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API endpoint from deprecated api.coindix to new api.nanoly #5849
Closed
davidtran001
wants to merge
18
commits into
OpenBB-finance:develop
from
davidtran001:hotfix/update-api-endpoint
Closed
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b75346e
Update API endpoint from deprecated api.coindix to new api.nanoly
davidtran001 d4646c2
Renamed coindix_model and coindix_view to nanoly_model anmd nanoly_vi…
davidtran001 96180cc
Replaced instances of coindix with nanoly in defi tests
davidtran001 ef49f95
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone 09e3f83
Changed data source from coindix to nanoly on screen
davidtran001 54d4257
Upated defi data source in defi_controller from coindix to nanoly
davidtran001 41f3e97
Merging with develop branch
davidtran001 a0085cd
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone dc3d56e
Renamed coindix models to nanoly model in sdk
davidtran001 6ccd76b
Deleted old coindix testing files
davidtran001 c852b02
Merge branch 'hotfix/update-api-endpoint' of github.com:davidtran001/…
davidtran001 2812e78
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone 8b925e2
Fixed openbb_terminal.cryptocurrency.defi imports such that they're i…
davidtran001 cdaf25a
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone 0a3ffaa
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone b60362c
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone db79720
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone 8b7bf30
Merge branch 'develop' into hotfix/update-api-endpoint
deeleeramone File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 0 additions & 41 deletions
41
...bb_terminal/cryptocurrency/defi/cassettes/test_coindix_view/test_display_defi_vaults.yaml
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is right here where Ruff is tripping. It wants to see these sorted alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
I have reordered the imports in
defi_controller.py
such that they're in alphabetical order in commit: 8b925e2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error with the related tests. I think you may have to re-capture the tests for the model, view and controller.
pytest tests/openbb_terminal/path_to/test_file.py --record-mode once --rewrite-expected
should get us there, allegedly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I have tried running the command you suggested but I can't get it to run on my machine locally.
The command:
and receive this error:
I have also ran
But received the same error.
Do you have any suggestions where to go from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooo.. looks like I missed a sub-folder (defi), sorry about that.
tests/openbb_terminal/cryptocurrency/defi/test_defi_controller.py