Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire reviewpad #5778

Closed
wants to merge 20 commits into from
Closed

Retire reviewpad #5778

wants to merge 20 commits into from

Conversation

piiq
Copy link
Contributor

@piiq piiq commented Nov 22, 2023

Replacing reviewpad's sanity checks with github actions following reviewpad being acquired by snyk

@piiq piiq added the do not merge Label to prevent pull request merge label Nov 22, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 22, 2023
@piiq piiq removed the feat XS Extra small feature label Nov 22, 2023
@reviewpad reviewpad bot added the feat XS Extra small feature label Nov 22, 2023
@reviewpad reviewpad bot added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Nov 22, 2023
@github-actions github-actions bot added the feat XS Extra small feature label Nov 22, 2023
@reviewpad reviewpad bot removed the feat XS Extra small feature label Nov 22, 2023
@piiq piiq added reviewpad-ignore and removed feat S Small T-Shirt size Feature labels Nov 22, 2023
@reviewpad reviewpad bot added the feat S Small T-Shirt size Feature label Nov 22, 2023
@github-actions github-actions bot added the feat XS Extra small feature label Nov 22, 2023
@piiq piiq removed the feat S Small T-Shirt size Feature label Nov 22, 2023
@piiq piiq changed the title Add github action with the same functionality as the reviewpad Retire reviewpad Nov 22, 2023
@piiq piiq removed do not merge Label to prevent pull request merge reviewpad-ignore labels Nov 22, 2023
@piiq
Copy link
Contributor Author

piiq commented Nov 22, 2023

I've actually tried to implement all the functionality we had offered by reviewpad, but working with diffs seemed to take more time than it's worth.
The challenge is that when I want to work on the contents of the diff I need to fetch the base branch which takes a lot of time given the size of our repo. Given the checks that reviewpad did were meant to be quick ones that preceded the tests and other actions waiting a few minutes to be bounced is not great.

@luqmanbello
Copy link
Contributor

luqmanbello commented Nov 23, 2023

I've actually tried to implement all the functionality we had offered by reviewpad, but working with diffs seemed to take more time than it's worth. The challenge is that when I want to work on the contents of the diff I need to fetch the base branch which takes a lot of time given the size of our repo. Given the checks that reviewpad did were meant to be quick ones that preceded the tests and other actions waiting a few minutes to be bounced is not great.

When I was working with git diff, it worked best with checkout v1 and you have to define the depth of what to fetch to improve speed. I would work on it and see what I can achieve

@jmaslek
Copy link
Collaborator

jmaslek commented Dec 5, 2023

@piiq @luqmanbello Is this mergable ?

@piiq
Copy link
Contributor Author

piiq commented Dec 6, 2023

For now this only adds the label. But in general yes. Reviewpad will be switched off pretty soon

@github-actions github-actions bot added the enhancement Enhancement label Jan 26, 2024
@piiq
Copy link
Contributor Author

piiq commented May 13, 2024

This is not relevant anymore

@piiq piiq closed this May 13, 2024
@piiq piiq deleted the feature/retire-reviewpad branch May 13, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants