Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic document queue #1364

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

Basic document queue #1364

wants to merge 5 commits into from
+107 −21

Conversation

michaelsharpe
Copy link
Contributor

What Changed:

  • new queue and worker added in to process documents
  • events emitted from the document service on progress and completion

How to test:

  • upload documents and ensure they are processed. I will be adding in some in IDE progress reporters to the UI.

Additional information:

Need to decide if we break this into a microservice or not.

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magick-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:05pm
magick-docs ❌ Failed (Inspect) Oct 24, 2023 10:05pm

benbot
benbot suggested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@benbot benbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the successful case, but we should also have a dead letter queue for tracking and retrying failed jobs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbot benbot benbot requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelsharpe @benbot