Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pending 3.8 #365

Merged
merged 6 commits into from
May 30, 2024
Merged

update pending 3.8 #365

merged 6 commits into from
May 30, 2024

Conversation

kathy-nevola
Copy link
Contributor

Title: Write a very short summary here

Problem: Write a description of your problem here.

Solution: Write a short summary of your solution.

Key Features:

  • Key feature 1
  • Key feature 2
  • ...

Checklist

  • Make sure you are requesting to pull a feature/bugfix branch (right side). This should not be main or develop.
  • Make sure you are make a pull request against either main or develop (left side). (Requesting to main should be reserved for bugfixes and new releases)
  • Add or update unit tests (if applicable)
  • Check your code with any unit tests (Run devtools::check() locally)
  • Add neccessary documentation (if applicable)

Type of changes

What type of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue) (link the issue on the right)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Documentation Update
  • Other (explain)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, any questions you have, etc...

Consider linking any issues (#issue-number ) or adding @mentions to ensure specific people see it.

OlinkAnalyze/NEWS.md Outdated Show resolved Hide resolved
@@ -41,8 +41,10 @@ Authors@R: c(
comment = c(Github = "olofmansson")),
person("Ola", "Caster", role = "ctb",
comment = c(Github = "OlaCaster")),
person("Kristyn", "Chin", role = "ctb",
person("Kristyn", "Chin", role = "aut",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only potential change - moving up below other authors for consistency. Not required though.

Copy link

@kristynchin-olink kristynchin-olink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only potential change is moving all authors into same section for consistency. However this is not required and all changes look good.

@kathy-nevola kathy-nevola requested review from kristynchin-olink and removed request for kristynchin-olink May 30, 2024 15:04
Copy link

@kristynchin-olink kristynchin-olink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authors moved together. All changes look good.

@kathy-nevola kathy-nevola merged commit 69f98e8 into develop May 30, 2024
4 of 9 checks passed
@kathy-nevola kathy-nevola deleted the news_3.8 branch May 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants