CI: Allow workflows running on pull request to run for any target branch #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a discussion a couple weeks ago, this removes the
branchesfiltering on pull requests, so it can be easier to test out pull requests on our forks (like me). Since we use rulesets in the repo that prevents branch creation, this additional filtering doesn't filter out any runs at all. Even if rulesets didn't prevent the workflows from creating branches in this repo, we might have wanted to have the workflows run on any such PR that targeted a branch that wasn't calledmainor didn't start withreleasebranch_.If ever the situation changes, the branches filter can be added back easily.