Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(window-level-region): add window level region tool #4127

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

Add window level region tool to the viewer in basic mode, segmentation, and test.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 949e721
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6660681c20743000087ebec3
😎 Deploy Preview https://deploy-preview-4127--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 949e721
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6660681cd50d2500088f450d
😎 Deploy Preview https://deploy-preview-4127--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi May 15, 2024 13:09
Copy link

cypress bot commented May 15, 2024

1 failed test on run #4040 ↗︎

1 43 2 0 Flakiness 0

Details:

update icons
Project: Viewers Commit: 949e72111b
Status: Failed Duration: 05:31 💡
Started: Jun 5, 2024 1:42 PM Ended: Jun 5, 2024 1:47 PM
Failed  cypress/integration/ImageConsistency.spec.js • 1 failed test

View Output Video

Test Artifacts
CS3D Image Consistency and Quality > TG18 Resolution Test Displayed 1:1 Test Replay Screenshots Video

Review all test suite changes for PR #4127 ↗︎

@sedghi sedghi requested a review from dan-rukas May 15, 2024 15:39
@IbrahimCSAE
Copy link
Collaborator Author

needs an icon @dan-rukas we also need an icon for cobb angle please.

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sedghi sedghi merged commit ab1a18a into master Jun 5, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants