Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_product_template: Migration to 17.0 #1178

Open
wants to merge 55 commits into
base: 17.0
Choose a base branch
from

Conversation

etobella
Copy link
Member

Refactorized using new OWL logic

/ocabot migration pos_product_template

@cvinh @luisDIXMIT

@pedrobaeza
Copy link
Member

/ocabot migration pos_product_template

Please check CI

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Apr 20, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 20, 2024
28 tasks
@etobella etobella force-pushed the 17.0-mig-pos_product_template branch from 0100e2d to 1b8ab79 Compare April 21, 2024 17:28
@etobella
Copy link
Member Author

@pedrobaeza error is unrelated. All tests are failing on 17.0. Fixed here #1179

@pedrobaeza
Copy link
Member

You can rebase now.

@etobella etobella force-pushed the 17.0-mig-pos_product_template branch from 1b8ab79 to 3d0d683 Compare April 21, 2024 20:04
Copy link
Contributor

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

@luisDIXMIT
Copy link

Tested on Runboat. There are two functionalities in the README file that may be failing. On one hand, the README file explains that if a product has variants, the number of variants should be shown instead of the price. However, nothing is displayed.

image

On the other hand, the variant attributes should function as filters, as explained in the README file, but it appears not to be working.

image

Could you please check this, @etobella? Maybe I'm interpreting the README file incorrectly. Thanks.

image

@etobella etobella force-pushed the 17.0-mig-pos_product_template branch from 3d0d683 to a226e1b Compare May 20, 2024 12:39
@etobella
Copy link
Member Author

@luisDIXMIT Reviewed, thanks!

oca-travis and others added 27 commits May 20, 2024 14:41
Currently translated at 100.0% (2 of 2 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
This can help perfs when there are templates with a lot of variants.

Also this adds a "confirm" button that can be a practical alternative to
the variant selection.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: pos-14.0/pos-14.0-pos_product_template
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_product_template/es/
@etobella etobella force-pushed the 17.0-mig-pos_product_template branch from a226e1b to 9244f91 Compare May 20, 2024 12:42
@etobella etobella force-pushed the 17.0-mig-pos_product_template branch from 9244f91 to e946284 Compare May 20, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet