Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] pos_product_warning #1139

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

MS-OSI
Copy link

@MS-OSI MS-OSI commented Jan 23, 2024

POS Product Warnings

This module displays product warnings while processing payments on the POS screen.

@MS-OSI
Copy link
Author

MS-OSI commented Jan 23, 2024

@dreispt

@MS-OSI MS-OSI force-pushed the 16.0-add-pos_product_warning branch from 37db292 to fada3b8 Compare January 23, 2024 08:00
@legalsylvain
Copy link
Contributor

Hi @MS-OSI.

Thanks for sharing your module.

Design question : There is a sale_line_warn_msg field, present in sale module. We could reuse this field instead of adding a new one, don't you think ?

Functional question : just tested on runboat. I think that the warning should be done when selecting the product (like in the sale and the purchase module)

  • homogeneous behaviour
  • if you go back on the product screen, you'll have twice the message
    Don't you think ?

@dreispt
Copy link
Sponsor Member

dreispt commented Jan 23, 2024

@legalsylvain I worked on the design for this, so I can share the thinking behind it.

We decided for a separate warning field, for flexibility.
This allows different warnings on different sales channels.
In case you want the same warning in both cases, it is not hard to automated the syncing between the two fields.

The main use case is to check for a person's ID in case of selling certain items, such as alcohol.
I don't want a check for each beer added.
I want to remind the operator to ask for ID because the sale includes alcoholic drinks.

_.pluck(_.pluck(orderlines, "product"), "pos_warn_msg")
);
if (productSaleWarningList.length > 0) {
const {confirmed} = await this.showPopup("ProductWarningPopup", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use 'SelectionPopup' instead of creating a new popup?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not use 'SelectionPopup' instead of creating a new popup?

SelectionPOPUP is used for the choice of item but in our case, it is a confirmation warning not choice of items that's why we create a new popup.

To confirm a message in SelectionPOPUP, you need to click on one of the message lines.

image

@legalsylvain
Copy link
Contributor

The main use case is to check for a person's ID in case of selling certain items, such as alcohol.
I don't want a check for each beer added.
I want to remind the operator to ask for ID because the sale includes alcoholic drinks.

Ow. I understand the use case. But in that case you describe, maybe if the message is at product category / pos.category level, it will be less configuration. In a "little" shop, you can have 200 products containing alcool. Set the message at product level can take time to configure. don't you think ?

@legalsylvain legalsylvain added this to the 16.0 milestone Feb 21, 2024
@cvinh
Copy link
Contributor

cvinh commented May 9, 2024

The main use case is to check for a person's ID in case of selling certain items, such as alcohol.
I don't want a check for each beer added.
I want to remind the operator to ask for ID because the sale includes alcoholic drinks.

Ow. I understand the use case. But in that case you describe, maybe if the message is at product category / pos.category level, it will be less configuration. In a "little" shop, you can have 200 products containing alcool. Set the message at product level can take time to configure. don't you think ?

It would be another module pos_category_warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants