Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): poor man PSC indicator badge #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yajo
Copy link
Member

@yajo yajo commented May 31, 2024

Provide a more ergonomic way for #140 (comment) to fix #140.

Provide a more ergonomic way for OCA#140 (comment) to fix OCA#140.
@yajo yajo self-assigned this May 31, 2024
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if it's not ideal.

Two suggestions:

  • Keep an issue open somewhere to tag this as in need of improvement.
  • Consider using DuckDuckGo instead of Google :)

@sbidoul
Copy link
Member

sbidoul commented Jun 1, 2024

We should rather link to https://oca.github.io/repo-maintainer-conf/, because https://odoo-community.org/psc-teams is unmaintained.

With some tweaks to https://github.com/OCA/repo-maintainer-conf/blob/master/.github/workflows/static.yml and the script it invokes, we should even be able to have a rich man solution.

@simahawk @etobella are we ready to remove https://odoo-community.org/psc-teams or replace it with redirects to https://oca.github.io/repo-maintainer-conf ?

@yajo
Copy link
Member Author

yajo commented Jun 5, 2024

We should rather link to https://oca.github.io/repo-maintainer-conf/, because https://odoo-community.org/psc-teams is unmaintained.

Sadly, we can't either:
image

@yajo
Copy link
Member Author

yajo commented Jun 5, 2024

With some tweaks to https://github.com/OCA/repo-maintainer-conf/blob/master/.github/workflows/static.yml and the script it invokes, we should even be able to have a rich man solution.

Do you think it's worth waiting for this to happen? Or could we merge this workaround and just update the badge url once the rich man solution lands?

@legalsylvain
Copy link
Contributor

Do you think it's worth waiting for this to happen?

As it is changing the template of OCA modules, better to not push a temporary solution IMO that will be replaced by another in a few time. Matter of taste, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README: Add PSC's in charge
4 participants