Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Propose Odoo as default version for recent version to avoid useless consumption of CI #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

Fix: #244

CC : @yajo, @sbidoul

@pedrobaeza
Copy link
Member

#244 (comment)

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is just changing the default, which means that all repos will stay as they are now unless manually changed.

OTOH, whenever we branch off 18.0, these will default to only use Odoo, which makes sense because there'll be no known difference with OCB at the day of launch.

In general I agree with this, as explained in the issue. Thanks!

Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that electricity savings outweigh the borderline needs of testing against both all the time.

Odoo (instead of OCB) is a good default, but I could be convinced both ways.

If we absolutely must test against both versions, we should exclusively do so on the main branch, not on the PRs, and also not on the ocabot branch.

@OCA-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Default odoo_test_flavor for recent version
5 participants